[PATCH] D42740: Implement a case-folding version of DJB hash

[David Blaikie via llvm-commits]

Jonas: I think the C++ comment is only required for headers - since the
file extension is ambiguous between C and C++

On Thu, Feb 1, 2018 at 8:36 AM Jonas Devlieghere via Phabricator <
reviews at reviews.llvm.org> wrote:

> JDevlieghere added inline comments.
>
>
> ================
> Comment at: lib/Support/UnicodeCaseFold.cpp:1
> +//===---------- Support/UnicodeCaseFold.cpp
> -------------------------------===//
> +//
> ----------------
> And here.
>
>
> ================
> Comment at: unittests/Support/DJBTest.cpp:1
> +//===---------- llvm/unittest/Support/DJBTest.cpp
> -------------------------===//
> +//
> ----------------
> Same here.
>
>
> ================
> Comment at: utils/unicode-case-fold.py:110
> +
> +print '//===---------- Support/UnicodeCaseFold.cpp
> -------------------------------===//'
> +print '//'
> ----------------
> Nit: missing `---*- C++ -*-===//` at the end.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D42740
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180201/a03d900e/attachment.html>