[PATCH] D42740: Implement a case-folding version of DJB hash

Jonas Devlieghere via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 1 08:46:08 PST 2018



> On Feb 1, 2018, at 4:42 PM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> Jonas: I think the C++ comment is only required for headers - since the file extension is ambiguous between C and C++

That would make sense. I opened a few files before writing that comment and both headers and implementation files seem to have this, maybe I got (un)lucky or maybe it’s just because people tend to copy/paste this.

> On Thu, Feb 1, 2018 at 8:36 AM Jonas Devlieghere via Phabricator <reviews at reviews.llvm.org> wrote:
> JDevlieghere added inline comments.
> 
> 
> ================
> Comment at: lib/Support/UnicodeCaseFold.cpp:1
> +//===---------- Support/UnicodeCaseFold.cpp -------------------------------===//
> +//
> ----------------
> And here.
> 
> 
> ================
> Comment at: unittests/Support/DJBTest.cpp:1
> +//===---------- llvm/unittest/Support/DJBTest.cpp -------------------------===//
> +//
> ----------------
> Same here.
> 
> 
> ================
> Comment at: utils/unicode-case-fold.py:110
> +
> +print '//===---------- Support/UnicodeCaseFold.cpp -------------------------------===//'
> +print '//'
> ----------------
> Nit: missing `---*- C++ -*-===//` at the end.
> 
> 
> Repository:
>   rL LLVM
> 
> https://reviews.llvm.org/D42740
> 
> 
> 



More information about the llvm-commits mailing list