[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

Andrew V. Tischenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 26 01:46:11 PST 2018


avt77 added inline comments.


================
Comment at: lib/AST/ExprClassification.cpp:652
+    if (Ctx.getCanonicalType(ASE->getBase()->getType()).isConstQualified())
+      return Cl::CM_ConstQualified;
+
----------------
rjmccall wrote:
> Is there a reason why the places that compute the type of these l-value expressions don't propagate qualiifers?  This hardly seems restricted to 'const'.
Do you mean ExtVectorElementExpr/ArraySubscriptExpr should retrun isConstQualified() == true by themselves (and other qualifiers as well)?


https://reviews.llvm.org/D42530





More information about the llvm-commits mailing list