[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

[John McCall via Phabricator via llvm-commits]

rjmccall added inline comments.


================
Comment at: lib/AST/ExprClassification.cpp:652
+    if (Ctx.getCanonicalType(ASE->getBase()->getType()).isConstQualified())
+      return Cl::CM_ConstQualified;
+
----------------
avt77 wrote:
> rjmccall wrote:
> > Is there a reason why the places that compute the type of these l-value expressions don't propagate qualiifers?  This hardly seems restricted to 'const'.
> Do you mean ExtVectorElementExpr/ArraySubscriptExpr should retrun isConstQualified() == true by themselves (and other qualifiers as well)?
In the sense that Sema should create them with a type that is const-qualified when the underlying vector l-value is const-qualified, yes.


https://reviews.llvm.org/D42530