[PATCH] D42377: [CodeGen] Use MIR syntax for MachineMemOperand printing

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 23 08:46:18 PST 2018


thegameg added inline comments.


================
Comment at: lib/CodeGen/MachineOperand.cpp:992
-  // pointer.
-  if (getBaseAlignment() != getAlignment())
-    OS << "(align=" << getBaseAlignment() << ")";
----------------
I just noticed this was printed before and won't be printed anymore after this patch.

IIUC, here we print the alignment of the base if it is affected by the offset, while in MIR and in this file at the line 999 we only care about the base alignment and only print the alignment of the whole reference.

Please correct me if I'm wrong.


https://reviews.llvm.org/D42377





More information about the llvm-commits mailing list