[PATCH] D42279: [WebAssembly] Don't duplicate strings in SYM_INFO subsection

[Nicholas Wilson via Phabricator via llvm-commits]

ncw accepted this revision.
ncw added a comment.
This revision is now accepted and ready to land.

This is really doubling-down on the current import-and-export strategy!

My concern now is #5 rebased on top of this will be larger, and have more test changes. Now that syminfo depends on the duplicate-imports, when they're taken away the diff is going to be that much bigger. I just don't see the incentive to merge #6 first, when my goal is to keep the diff to an absolute minimum in commits like #5 which are "contentful" changes. The order of changes I'd come up was based on trying to minimise the number of times the tests would have to be updated (to reduce the chance of masking a bug by updating the same things repeatedly).

This change is using/abusing the Wasm indexes in the same way as my #2, but #2 really //had// to land before #5, whereas this is just a cosmetic change to reduce filesize, and doesn't really need to.

Hmm. It looks like it should work, so I guess your order is OK. Thanks for helping me land the changes!


Repository:
  rL LLVM

https://reviews.llvm.org/D42279