[PATCH] D42279: [WebAssembly] Don't duplicate strings in SYM_INFO subsection

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added inline comments.


================
Comment at: include/llvm/Object/Wasm.h:268
+  // Map pair(kind,index) -> symbol index
+  DenseMap<std::pair<uint32_t, uint32_t>, uint32_t> SymbolMap;
 };
----------------
It's a shame we need two maps now! I think it my patch order, we were able to change the map's type in one commit, then remove it in the next.


================
Comment at: lib/MC/WasmObjectWriter.cpp:1045
+                 : 0;
+    SymbolInfo.emplace_back(WasmSymInfo{Kind, Index, Flags});
+  };
----------------
You've dropped a `if (Flags != 0)` check.


Repository:
  rL LLVM

https://reviews.llvm.org/D42279