[PATCH] D42214: libcxx: Move Windows threading support into a .cpp file.

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

With that said, I'd be fine with this patch as-is (once the critical section issue is fixed); we can always restore the inlining later whenever someone gets the time/if it does turn out to be an issue. libc++ on Windows will miss out on lots of inlining opportunities because of dllimport anyway (clang doesn't inline a dllimport function if it calls a non-dllimport function, which pessimizes lots of libc++ dllimport functions which call trivial non-dllimport helpers, e.g. `basic_string::data` calling `_VSTD::__to_raw_pointer`), so there are bigger problems already.


https://reviews.llvm.org/D42214