[PATCH] D42214: libcxx: Move Windows threading support into a .cpp file.

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

> It doesn't seem like a big problem to me. Many of these APIs will result in system calls, and the cost of not inlining is probably dwarfed by the cost of the system call.

They'll only cause system calls in case of contention, right? SRWLock in particular is supposed to be super lightweight. I agree that it's probably not a huge deal in practice, but it seems like if you already have to provide some fake types to make the header happy, you might as well go all the way with your own prototypes.


https://reviews.llvm.org/D42214