[PATCH] D41695: [Metadata] Extend 'count' field of DISubrange to take a metadata node

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 10:14:52 PST 2018


aprantl added a comment.

The fact that we are using a ConstantInt for the constants has me slightly concerned. What happens when a global points to the same ConstantInt and is optimized away? Will it also delete the ConstantInt as its last non-metadata user?

We could instead store a `union { DIVariable *, int64_t };` and put a discriminator bit into the SubclassData32 or somewhere.


https://reviews.llvm.org/D41695





More information about the llvm-commits mailing list