[PATCH] D41695: [Metadata] Extend 'count' field of DISubrange to take a metadata node

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 10:00:58 PST 2018


aprantl added a comment.

In https://reviews.llvm.org/D41695#980445, @sdesmalen wrote:

> - Added versioning of the DISubrange node and added a corresponding unit test (.ll and .ll.bc) to test parsing of bitcode files generated from older versions of LLVM.
> - Changed 'getCount()' -> 'getConstantCountOrNull()'.
> - Changed 'getCountVariable()' -> 'getCountVariableOrNull()'


Sorry for making you do all these tiny incremental revisions, and this is clearly entering the realm of diminishing returns, but:

we could also have a single

`PointerUnion<ConstantInt,  DIlVariable> getCount()`

method.


https://reviews.llvm.org/D41695





More information about the llvm-commits mailing list