[PATCH] D38313: [InstCombine] Introducing Aggressive Instruction Combine pass

Amjad Aboud via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 14 06:59:22 PST 2018


aaboud added a comment.

In https://reviews.llvm.org/D38313#971848, @mzolotukhin wrote:

> Hi and sorry for the late reply, I've just returned from the holidays break.
>  The numbers posted before look good. I wonder though if it would make sense to only run this pass on -O3. I assume that even if now the pass spends very little time, it will grow in future and the compile-time costs might become noticeable.
>
> Michael


Thanks Michael for the feedback.
As you said, the pass spend very little time, cannot we decide on moving it to -O3 in the future when/if  other heavy optimizations is added to this pass?
And even then, we can decide to run part of them on -O2 and the rest on -O3.

Would that work for you?

Thanks,
Amjad


https://reviews.llvm.org/D38313





More information about the llvm-commits mailing list