[PATCH] D40776: [X86][AVX512]: Adding full coverage of MC encoding for the AVX512 isa sets (w/o AVX512F).<NFC>

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: test/MC/X86/AVX512BW_128N-64.s:4
+// CHECK: pextrb $0, %xmm15, 64(%rdx,%rax,4) 
+// CHECK: encoding: [0x66,0x44,0x0f,0x3a,0x14,0x7c,0x82,0x40,0x00]      
+pextrb $0, %xmm15, 64(%rdx,%rax,4) 
----------------
This is a legacy SSE instruction. It shoudldn't be here.


================
Comment at: test/MC/X86/AVX512BW_128N-64.s:12
+// CHECK: vpextrb $0, %xmm1, 485498096 
+// CHECK: encoding: [0xc4,0xe3,0x79,0x14,0x0c,0x25,0xf0,0x1c,0xf0,0x1c,0x00]      
+vpextrb $0, %xmm1, 485498096 
----------------
This is testing the VEX encoded version not the EVEX encoded version. The encoding for EVEX should start with 0x62. I believe this problem exists in a lot of the tests without masking.


Repository:
  rL LLVM

https://reviews.llvm.org/D40776