[PATCH] D41693: [ARM][NFC] Avoid recreating MCSubtargetInfo in ARMAsmBackend

Alex Bradbury via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 9 06:15:30 PST 2018


On 8 January 2018 at 17:10, David Blaikie via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> No test coverage?
>
> I'm assuming creating the MCSubtargetInfo with the function's feature string
> (rather than an empty string) would fix bugs where function-specific feature
> strings were not respected? Perhaps an example of that could be tested?

That could make sense. The change is motivated primarily by code
cleanup rather than addressing any known bug. I would think observable
differences in behaviour could be observed in tests like
t2-modified-immediate-fixup-error{1,2}.s, but I can't see an
appropriate baseline -march to use.  Suggestions from those of you
more familiar with the Arm product line would be welcome. Any ideas
anyone?

Thanks,

Alex


More information about the llvm-commits mailing list