[PATCH] D41693: [ARM][NFC] Avoid recreating MCSubtargetInfo in ARMAsmBackend

[David Blaikie via llvm-commits]

No test coverage?

I'm assuming creating the MCSubtargetInfo with the function's feature
string (rather than an empty string) would fix bugs where function-specific
feature strings were not respected? Perhaps an example of that could be
tested?

On Wed, Jan 3, 2018 at 2:20 AM Alex Bradbury via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> asb created this revision.
> asb added reviewers: fhahn, rengolin.
> Herald added subscribers: kristof.beyls, javed.absar, aemerson.
>
> After https://reviews.llvm.org/D41349, we can now directly access
> MCSubtargetInfo from createARM*AsmBackend. This patch makes use of this,
> avoiding the need to create a fresh MCSubtargetInfo (which was previously
> always done with a blank CPU and feature string). Given the total size of
> the change remains pretty tiny and we're removing the old explicit
> destructor, I changed the STI field to a reference rather than a pointer.
>
>
> https://reviews.llvm.org/D41693
>
> Files:
>   lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
>   lib/Target/ARM/MCTargetDesc/ARMAsmBackend.h
>   lib/Target/ARM/MCTargetDesc/ARMAsmBackendDarwin.h
>   lib/Target/ARM/MCTargetDesc/ARMAsmBackendELF.h
>   lib/Target/ARM/MCTargetDesc/ARMAsmBackendWinCOFF.h
>   lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.h
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180108/053d19b9/attachment.html>