[PATCH] D41599: [X86] Lowering X86 avx512 sqrt intrinsics to IR - LLVM

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: test/CodeGen/X86/sse-intrinsics-x86.ll:476
 }
-declare <4 x float> @llvm.x86.sse.sqrt.ps(<4 x float>) nounwind readnone
+declare void @llvm.x86.sse.stmxcsr(i8*) nounwind
 
----------------
Why did you move this test?


================
Comment at: test/CodeGen/X86/sse2-intrinsics-fast-isel.ll:2954
 }
-declare <2 x double> @llvm.x86.sse2.sqrt.pd(<2 x double>) nounwind readnone
+declare <2 x double> @llvm.sqrt.v2f32(<2 x double>) nounwind readnone
 
----------------
Shouldn't that be llvm.sqrt.v2f64?


================
Comment at: test/CodeGen/X86/sse2-intrinsics-x86-upgrade.ll:20
+; SKX-NEXT:    retl ## encoding: [0xc3]
+  %res = call <2 x double> @llvm.x86.sse2.sqrt.pd(<2 x double> %a0) ; <<2 x double>> [#uses=1]
+  ret <2 x double> %res
----------------
Strip these checks and regenerate


https://reviews.llvm.org/D41599