[PATCH] D41338: [CodeGen] lower math intrinsics to finite version of libcalls when possible (PR35672)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D41338#960487, @hfinkel wrote:

> In https://reviews.llvm.org/D41338#958611, @efriedma wrote:
>
> > > Does this make sense for ISD::STRICT_FEXP (the strict version of the node)?
> >
> > I would guess strict and fast math don't really mix...
>
>
> I agree.


Sorry for the delay. Let me address this comment first. I would agree too, but I was informed that there's a clang customer in the gaming world that wants to compile with -ffast-math **and** enable div-by-zero FP exceptions as a way to sanitize their data (at least in development builds).

I assume that we're still a long way from realizing this dream (optimized FP + some subset of FP exceptions enabled) in LLVM, but if there's no correctness issue with allowing this transform, then I think we should treat these nodes the same in this patch.


https://reviews.llvm.org/D41338