[PATCH] D41497: [ThinLTO][CachePruning] explicitly disable pruning

ben via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 22 08:16:01 PST 2017

bd1976llvm marked an inline comment as done.
bd1976llvm added a comment.

In https://reviews.llvm.org/D41497#963176, @tejohnson wrote:

> Thanks this looks much nicer. Question below about the handling of the Optional though.
> As an aside, it would be great to have similar handling in parseCachePruningPolicy(), which is used by gold-plugin and lld, and which gives an error when -1 is passed as the interval. But that doesn't need to be in this patch, just noting it here.

If possible I would rather do that in another change.

Comment at: lib/Support/CachePruning.cpp:170
+      return false;
     if (Policy.Interval != seconds(0)) {
       // Check whether the time stamp is older than our pruning interval.
tejohnson wrote:
> Wouldn't this need to be *Policy.Interval, like in the below <= check?
The != operator is overloaded so it does the right thing.


More information about the llvm-commits mailing list