[PATCH] D41497: [ThinLTO][CachePruning] explicitly disable pruning

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 22 07:29:31 PST 2017

tejohnson added a comment.

Thanks this looks much nicer. Question below about the handling of the Optional though.

As an aside, it would be great to have similar handling in parseCachePruningPolicy(), which is used by gold-plugin and lld, and which gives an error when -1 is passed as the interval. But that doesn't need to be in this patch, just noting it here.

Comment at: lib/Support/CachePruning.cpp:170
+      return false;
     if (Policy.Interval != seconds(0)) {
       // Check whether the time stamp is older than our pruning interval.
Wouldn't this need to be *Policy.Interval, like in the below <= check?


More information about the llvm-commits mailing list