[PATCH] D41226: LiveDebugValues spill recognition expasnsion

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 18 09:16:57 PST 2017

aprantl added a comment.

Thanks, I can run the test now. Unfortunately it looks like the test is not yet sufficient (see inline comment).

Comment at: lib/CodeGen/LiveDebugValues.cpp:451
+            if (RegNext == Reg) {
+              Reg = RegNext;
+              break;
aprantl wrote:
> Isn't that a no-op?
The test still passes when I comment out line 449-450. Could you add coverage for these two lines, too?


More information about the llvm-commits mailing list