llvm-commits Digest, Vol 162, Issue 194

[George Rimar via llvm-commits]

Hi James,


FWIW I am using TortoiseSVN too, I am only using command line + notepad++ to create patches with context

and to change CRLF->LF. I am using TortoiseSVN ?UI when doing commits.


Best regards,
George | Developer | Access Softek, Inc
________________________________
От: James Henderson <jh7370.2008 at my.bristol.ac.uk>
Отправлено: 13 декабря 2017 г. 15:14
Кому: George Rimar
Копия: rafael.espindola at gmail.com; llvm-commits at lists.llvm.org; llvm-commits-request at lists.llvm.org
Тема: Re: llvm-commits Digest, Vol 162, Issue 194

Hi George,

I do use basically that process when creating diffs for uploading to Phabricator, although the last time prior to Rafael's review that I created the diff for the patch was before I added a dos2unix step on the patch file. The problem comes when using TortoiseSVN's SVN Commit UI option - it appears to do some carriage-return messing about somewhere behind the scenes (the files use \n endings locally prior to the commit). I don't know if this is a problem with svn in general, or TortoiseSVN in particular. Next time I make a commit, I'll try doing it via the command-line, and see whether that makes any difference.

James

On 13 December 2017 at 10:38, George Rimar via llvm-commits <llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>> wrote:
>Hi Rafael,
>
>I develop on Windows, using SVN. I made sure that none of the changes I
>made had CRLF in my local files, prior to commit, so this can only have
>happened at the point of commit. I have been unable to find any setting on
>my side that changes the nature of line-endings on commit, and I'm aware
>that there was some issue previously with explicitly setting SVN properties
>on the individual files. Please let me know if you are aware of any other
>method for avoiding this when using SVN on Windows.
>
>James

Let me share following info. I worked on LLD for about 2+ years and main OS I am using and use is
windows. Following list works for me and I hope you could use it:

1) clang format plugin for MSVS is https://llvm.org/builds.
2) I have plugin that highlights excessive spaces symbols, sorry did not find where I took it from,
     but it works nice.
3) Before posting patch I am doing "svn diff --diff-cmd=diff  -X -U999999 > patch.patch" and
after that convert the result patch.patch using notepad++ to use LF instead CRLF.

George.
_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171214/b7b3c33a/attachment.html>