<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=koi8-r">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>Hi James,<br>
</p>
<p><br>
</p>
<p>FWIW I am using TortoiseSVN too, I am only using command line + notepad++ to create patches with context</p>
<p><span style="font-size: 12pt;">and to change CRLF->LF</span><span style="font-size: 12pt;">. I am using
<span style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px; background-color: rgb(255, 255, 255);">
TortoiseSVN</span><span style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px; background-color: rgb(255, 255, 255);"> </span>UI when doing commits.</span></p>
<p><br>
</p>
<div id="Signature">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div class="BodyFragment"><font size="2">
<div class="PlainText">Best regards,<br>
George | Developer | <span style="background-color:rgb(255,255,255); color:rgb(33,33,33); font-family:Calibri,sans-serif; font-size:13.3333px">Access Softek, Inc</span></div>
</font></div>
</div>
</div>
<div style="color: rgb(33, 33, 33);">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>От:</b> James Henderson <jh7370.2008@my.bristol.ac.uk><br>
<b>Отправлено:</b> 13 декабря 2017 г. 15:14<br>
<b>Кому:</b> George Rimar<br>
<b>Копия:</b> rafael.espindola@gmail.com; llvm-commits@lists.llvm.org; llvm-commits-request@lists.llvm.org<br>
<b>Тема:</b> Re: llvm-commits Digest, Vol 162, Issue 194</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div>
<div>Hi George,<br>
<br>
</div>
I do use basically that process when creating diffs for uploading to Phabricator, although the last time prior to Rafael's review that I created the diff for the patch was before I added a dos2unix step on the patch file. The problem comes when using TortoiseSVN's
SVN Commit UI option - it appears to do some carriage-return messing about somewhere behind the scenes (the files use \n endings locally prior to the commit). I don't know if this is a problem with svn in general, or TortoiseSVN in particular. Next time I
make a commit, I'll try doing it via the command-line, and see whether that makes any difference.<br>
<br>
</div>
James<br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 13 December 2017 at 10:38, George Rimar via llvm-commits
<span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
>Hi Rafael,<br>
><br>
>I develop on Windows, using SVN. I made sure that none of the changes I<br>
>made had CRLF in my local files, prior to commit, so this can only have<br>
>happened at the point of commit. I have been unable to find any setting on<br>
>my side that changes the nature of line-endings on commit, and I'm aware<br>
>that there was some issue previously with explicitly setting SVN properties<br>
>on the individual files. Please let me know if you are aware of any other<br>
>method for avoiding this when using SVN on Windows.<br>
><br>
>James<br>
<br>
Let me share following info. I worked on LLD for about 2+ years and main OS I am using and use is<br>
windows. Following list works for me and I hope you could use it:<br>
<br>
1) clang format plugin for MSVS is <a href="https://llvm.org/builds" rel="noreferrer" target="_blank">
https://llvm.org/builds</a>.<br>
2) I have plugin that highlights excessive spaces symbols, sorry did not find where I took it from,<br>
but it works nice.<br>
3) Before posting patch I am doing "svn diff --diff-cmd=diff -X -U999999 > patch.patch" and<br>
after that convert the result patch.patch using notepad++ to use LF instead CRLF.<br>
<br>
George.<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</body>
</html>