[PATCH] D41146: [DWARF] DWARF v5: Rework of string offsets table reader

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFUnit.cpp:570
+    parseDWARF64StringOffsetsTableHeader(DA, HeaderOffset, Descriptor);
+    if (!Descriptor.Valid) {
+      Descriptor.Valid = true;
----------------
aprantl wrote:
> The way that the Valid flag is set as a side-efffect here is a bit difficult to follow. Could it perhaps be a return value of parseDWARF64StringOffsetsTableHeader?
Sure. I'll bury the resetting of the valid bit inside the parseDWARF* functions as well to localize it a bit more.


https://reviews.llvm.org/D41146