[PATCH] D41146: [DWARF] DWARF v5: Rework of string offsets table reader

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFUnit.h:173
+  DWARFFormParams FormParams = {0, 0, dwarf::DwarfFormat::DWARF32}; // Format and version.
+  bool Valid = false; // False for an ill-formed or non-existent contribution.
+
----------------
`///` and on line above, so it gets picked up by Doxygen?


================
Comment at: lib/DebugInfo/DWARF/DWARFUnit.cpp:570
+    parseDWARF64StringOffsetsTableHeader(DA, HeaderOffset, Descriptor);
+    if (!Descriptor.Valid) {
+      Descriptor.Valid = true;
----------------
The way that the Valid flag is set as a side-efffect here is a bit difficult to follow. Could it perhaps be a return value of parseDWARF64StringOffsetsTableHeader?


https://reviews.llvm.org/D41146