[lld] r320472 - [ELF] Reset OutputSection size prior to processing linker script commands

[James Henderson via llvm-commits]

Hi Rafael,

I develop on Windows, using SVN. I made sure that none of the changes I
made had CRLF in my local files, prior to commit, so this can only have
happened at the point of commit. I have been unable to find any setting on
my side that changes the nature of line-endings on commit, and I'm aware
that there was some issue previously with explicitly setting SVN properties
on the individual files. Please let me know if you are aware of any other
method for avoiding this when using SVN on Windows.

James

On 12 December 2017 at 17:38, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> James Henderson via llvm-commits <llvm-commits at lists.llvm.org> writes:
>
> > Modified: lld/trunk/ELF/InputSection.h
> > URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/
> InputSection.h?rev=320472&r1=320471&r2=320472&view=diff
> > ============================================================
> ==================
> > --- lld/trunk/ELF/InputSection.h (original)
> > +++ lld/trunk/ELF/InputSection.h Tue Dec 12 03:51:13 2017
> > @@ -318,13 +318,15 @@ public:
> >
> >    OutputSection *getParent() const;
> >
> > -  // The offset from beginning of the output sections this section was
> assigned
> > -  // to. The writer sets a value.
> > -  uint64_t OutSecOff = 0;
> > -
> > -  static bool classof(const SectionBase *S);
> > -
> > -  InputSectionBase *getRelocatedSection();
> > +  // This variable has two usages. Initially, it represents an index in
> the
> > +  // OutputSection's InputSection list, and is used when ordering
> SHF_LINK_ORDER
> > +  // sections. After assignAddresses is called, it represents the
> offset from
> > +  // the beginning of the output section this section was assigned to.
> > +  uint64_t OutSecOff = 0;
> > +
> > +  static bool classof(const SectionBase *S);
> > +
> > +  InputSectionBase *getRelocatedSection();
>
> Some of these differences were because of CRLF line endings. Please
> avoid them in the future.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171213/5e6be125/attachment.html>