[lld] r320472 - [ELF] Reset OutputSection size prior to processing linker script commands

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 12 09:38:52 PST 2017


James Henderson via llvm-commits <llvm-commits at lists.llvm.org> writes:

> Modified: lld/trunk/ELF/InputSection.h
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputSection.h?rev=320472&r1=320471&r2=320472&view=diff
> ==============================================================================
> --- lld/trunk/ELF/InputSection.h (original)
> +++ lld/trunk/ELF/InputSection.h Tue Dec 12 03:51:13 2017
> @@ -318,13 +318,15 @@ public:
>  
>    OutputSection *getParent() const;
>  
> -  // The offset from beginning of the output sections this section was assigned
> -  // to. The writer sets a value.
> -  uint64_t OutSecOff = 0;
> -
> -  static bool classof(const SectionBase *S);
> -
> -  InputSectionBase *getRelocatedSection();
> +  // This variable has two usages. Initially, it represents an index in the
> +  // OutputSection's InputSection list, and is used when ordering SHF_LINK_ORDER
> +  // sections. After assignAddresses is called, it represents the offset from
> +  // the beginning of the output section this section was assigned to.
> +  uint64_t OutSecOff = 0;
> +
> +  static bool classof(const SectionBase *S);
> +
> +  InputSectionBase *getRelocatedSection();

Some of these differences were because of CRLF line endings. Please
avoid them in the future.

Cheers,
Rafael


More information about the llvm-commits mailing list