[PATCH] D41040: [DAGCombiner] protect against an infinite loop between shl <--> mul (PR35579)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 10 09:09:56 PST 2017


RKSimon added a reviewer: RKSimon.
RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2678
+      DAG.isKnownToBeAPowerOfTwo(N1) &&
+      (!VT.isVector() || Level <= AfterLegalizeVectorOps)) {
     SDLoc DL(N);
----------------
This looks OK, but would !LegalOperations || TLI.isOperationLegal(ISD::SHL, VT) be better?


https://reviews.llvm.org/D41040





More information about the llvm-commits mailing list