Re: [PATCH] D39567: [lit] Implement non-pipelined ‘mkdir’, ‘diff’ and ‘rm’ commands internally

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 29 11:39:09 PST 2017


Honestly there's a lot of weird stuff that tests are already doing that i
don't think we should encourage.

I won't block the change, but I do at least want to get a second opinion
because ideally in the long run I'd like to converge on the simplest set of
shell features that is expressive enough to handle 99% of what users need.

@rnk: What do you think?

On Wed, Nov 29, 2017 at 1:14 AM Ying Yi <maggieyi666 at gmail.com> wrote:

> Hi Zachary, I agree with you that we shouldn’t support every weird thing
> a test is doing. However, we may want to support a set of features that was
> supported before. The sequential commands are supported before. I think I
> missed this feature in the internal ‘mkdir’, ‘rm’ and ‘diff’ commands.
> Therefore, I updated the internal commands of ‘mkdir’, ‘rm’ and ‘diff’ to
> support this feature. Please let me know what do you think? Maggie
>
> On Tue, Nov 28, 2017 at 4:28 PM, Zachary Turner <zturner at google.com>
> wrote:
>
>> I think if we go down this rabbit hole of trying to support every weird
>> thing a test is doing it’s going to go very deep and add a lot of
>> complexity and technical debt while never being fully correct.
>>
>> Can we just update the test to use mkdir -p?
>>
>> On Tue, Nov 28, 2017 at 3:19 AM Ying Yi via Phabricator <
>> reviews at reviews.llvm.org> wrote:
>>
>>> MaggieYi updated this revision to Diff 124534.
>>> MaggieYi added a comment.
>>>
>>> The previous patch doesn’t support the sequential commands, for example
>>> “mkdir existing_folder || true”. This caused sanitizer-windows test
>>> failed.  The patch has been updated to support  the sequential commands.
>>>
>>>
>>> https://reviews.llvm.org/D39567
>>>
>>> Files:
>>>   utils/lit/lit/TestRunner.py
>>>   utils/lit/tests/Inputs/shtest-shell/check_path.py
>>>   utils/lit/tests/Inputs/shtest-shell/diff-error-0.txt
>>>   utils/lit/tests/Inputs/shtest-shell/diff-error-1.txt
>>>   utils/lit/tests/Inputs/shtest-shell/diff-error-2.txt
>>>   utils/lit/tests/Inputs/shtest-shell/diff-error-3.txt
>>>   utils/lit/tests/Inputs/shtest-shell/diff-error-4.txt
>>>   utils/lit/tests/Inputs/shtest-shell/diff-error-5.txt
>>>   utils/lit/tests/Inputs/shtest-shell/diff-error-6.txt
>>>   utils/lit/tests/Inputs/shtest-shell/mkdir-error-0.txt
>>>   utils/lit/tests/Inputs/shtest-shell/mkdir-error-1.txt
>>>   utils/lit/tests/Inputs/shtest-shell/mkdir-error-2.txt
>>>   utils/lit/tests/Inputs/shtest-shell/rm-error-0.txt
>>>   utils/lit/tests/Inputs/shtest-shell/rm-error-1.txt
>>>   utils/lit/tests/Inputs/shtest-shell/rm-error-2.txt
>>>   utils/lit/tests/Inputs/shtest-shell/rm-error-3.txt
>>>   utils/lit/tests/Inputs/shtest-shell/valid-shell.txt
>>>   utils/lit/tests/max-failures.py
>>>   utils/lit/tests/shtest-shell.py
>>>
>>>
>
>
> --
> Ying Yi
> SN Systems - Sony Interactive Entertainment
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171129/e3ecf2c1/attachment.html>


More information about the llvm-commits mailing list