<div dir="ltr">Honestly there's a lot of weird stuff that tests are already doing that i don't think we should encourage.<div><br></div><div>I won't block the change, but I do at least want to get a second opinion because ideally in the long run I'd like to converge on the simplest set of shell features that is expressive enough to handle 99% of what users need.<div><br></div><div>@rnk: What do you think?</div></div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Nov 29, 2017 at 1:14 AM Ying Yi <<a href="mailto:maggieyi666@gmail.com">maggieyi666@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">

<h3><span style="font-size:11pt;font-weight:normal">Hi
Zachary,</span></h3>

<h3><span style="font-size:11pt;font-weight:normal">I
agree with you that we shouldn’t support every weird thing a test is doing.
However, we may want to support a set of features that was supported before. The
sequential commands are supported before. I think I missed this feature in the
internal ‘mkdir’, ‘rm’ and ‘diff’ commands. Therefore, I updated the internal commands
of ‘mkdir’, ‘rm’ and ‘diff’ to support this feature.</span></h3>

<h3><span style="font-size:11pt;font-weight:normal">Please
let me know what do you think?</span></h3>

<h3><span style="font-size:11pt;font-weight:normal">Maggie</span></h3>

</div><div class="gmail_extra"></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 28, 2017 at 4:28 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I think if we go down this rabbit hole of trying to support every weird thing a test is doing it’s going to go very deep and add a lot of complexity and technical debt while never being fully correct.<br><br>Can we just update the test to use mkdir -p?<div class="m_3926363153406001745HOEnZb"><div class="m_3926363153406001745h5"><br><div class="gmail_quote"><div dir="ltr">On Tue, Nov 28, 2017 at 3:19 AM Ying Yi via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">MaggieYi updated this revision to Diff 124534.<br>
MaggieYi added a comment.<br>
<br>
The previous patch doesn’t support the sequential commands, for example “mkdir existing_folder || true”. This caused sanitizer-windows test failed.  The patch has been updated to support  the sequential commands.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D39567" rel="noreferrer" target="_blank">https://reviews.llvm.org/D39567</a><br>
<br>
Files:<br>
  utils/lit/lit/TestRunner.py<br>
  utils/lit/tests/Inputs/shtest-shell/check_path.py<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-0.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-1.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-2.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-3.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-4.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-5.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-6.txt<br>
  utils/lit/tests/Inputs/shtest-shell/mkdir-error-0.txt<br>
  utils/lit/tests/Inputs/shtest-shell/mkdir-error-1.txt<br>
  utils/lit/tests/Inputs/shtest-shell/mkdir-error-2.txt<br>
  utils/lit/tests/Inputs/shtest-shell/rm-error-0.txt<br>
  utils/lit/tests/Inputs/shtest-shell/rm-error-1.txt<br>
  utils/lit/tests/Inputs/shtest-shell/rm-error-2.txt<br>
  utils/lit/tests/Inputs/shtest-shell/rm-error-3.txt<br>
  utils/lit/tests/Inputs/shtest-shell/valid-shell.txt<br>
  utils/lit/tests/max-failures.py<br>
  utils/lit/tests/shtest-shell.py<br>
<br>
</blockquote></div>
</div></div></blockquote></div><br><br clear="all"><br></div><div class="gmail_extra">-- <br><div class="m_3926363153406001745gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><font size="2"><span style="font-family:arial,helvetica,sans-serif"></span></font><font face="Calibri" size="2"><span style="font-size:11pt"><font size="2"><span style="font-size:10pt"><font color="#1F497D" face="Arial">Ying Yi<br>SN Systems - Sony Interactive Entertainment</font></span></font></span></font><br></div></div></div></div></div></div></div></div>
</div></blockquote></div>