Re: [PATCH] D39567: [lit] Implement non-pipelined ‘mkdir’, ‘diff’ and ‘rm’ commands internally

[Zachary Turner via llvm-commits]

I think if we go down this rabbit hole of trying to support every weird
thing a test is doing it’s going to go very deep and add a lot of
complexity and technical debt while never being fully correct.

Can we just update the test to use mkdir -p?
On Tue, Nov 28, 2017 at 3:19 AM Ying Yi via Phabricator <
reviews at reviews.llvm.org> wrote:

> MaggieYi updated this revision to Diff 124534.
> MaggieYi added a comment.
>
> The previous patch doesn’t support the sequential commands, for example
> “mkdir existing_folder || true”. This caused sanitizer-windows test
> failed.  The patch has been updated to support  the sequential commands.
>
>
> https://reviews.llvm.org/D39567
>
> Files:
>   utils/lit/lit/TestRunner.py
>   utils/lit/tests/Inputs/shtest-shell/check_path.py
>   utils/lit/tests/Inputs/shtest-shell/diff-error-0.txt
>   utils/lit/tests/Inputs/shtest-shell/diff-error-1.txt
>   utils/lit/tests/Inputs/shtest-shell/diff-error-2.txt
>   utils/lit/tests/Inputs/shtest-shell/diff-error-3.txt
>   utils/lit/tests/Inputs/shtest-shell/diff-error-4.txt
>   utils/lit/tests/Inputs/shtest-shell/diff-error-5.txt
>   utils/lit/tests/Inputs/shtest-shell/diff-error-6.txt
>   utils/lit/tests/Inputs/shtest-shell/mkdir-error-0.txt
>   utils/lit/tests/Inputs/shtest-shell/mkdir-error-1.txt
>   utils/lit/tests/Inputs/shtest-shell/mkdir-error-2.txt
>   utils/lit/tests/Inputs/shtest-shell/rm-error-0.txt
>   utils/lit/tests/Inputs/shtest-shell/rm-error-1.txt
>   utils/lit/tests/Inputs/shtest-shell/rm-error-2.txt
>   utils/lit/tests/Inputs/shtest-shell/rm-error-3.txt
>   utils/lit/tests/Inputs/shtest-shell/valid-shell.txt
>   utils/lit/tests/max-failures.py
>   utils/lit/tests/shtest-shell.py
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171128/9de283e2/attachment.html>