I think if we go down this rabbit hole of trying to support every weird thing a test is doing it’s going to go very deep and add a lot of complexity and technical debt while never being fully correct.<br><br>Can we just update the test to use mkdir -p?<br><div class="gmail_quote"><div dir="ltr">On Tue, Nov 28, 2017 at 3:19 AM Ying Yi via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">MaggieYi updated this revision to Diff 124534.<br>
MaggieYi added a comment.<br>
<br>
The previous patch doesn’t support the sequential commands, for example “mkdir existing_folder || true”. This caused sanitizer-windows test failed.  The patch has been updated to support  the sequential commands.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D39567" rel="noreferrer" target="_blank">https://reviews.llvm.org/D39567</a><br>
<br>
Files:<br>
  utils/lit/lit/TestRunner.py<br>
  utils/lit/tests/Inputs/shtest-shell/check_path.py<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-0.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-1.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-2.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-3.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-4.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-5.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-6.txt<br>
  utils/lit/tests/Inputs/shtest-shell/mkdir-error-0.txt<br>
  utils/lit/tests/Inputs/shtest-shell/mkdir-error-1.txt<br>
  utils/lit/tests/Inputs/shtest-shell/mkdir-error-2.txt<br>
  utils/lit/tests/Inputs/shtest-shell/rm-error-0.txt<br>
  utils/lit/tests/Inputs/shtest-shell/rm-error-1.txt<br>
  utils/lit/tests/Inputs/shtest-shell/rm-error-2.txt<br>
  utils/lit/tests/Inputs/shtest-shell/rm-error-3.txt<br>
  utils/lit/tests/Inputs/shtest-shell/valid-shell.txt<br>
  utils/lit/tests/max-failures.py<br>
  utils/lit/tests/shtest-shell.py<br>
<br>
</blockquote></div>