[PATCH] D40492: Handle Top-Level-Regions in polly::isHoistableLoad

[Philip Pfaffe via Phabricator via llvm-commits]

philip.pfaffe added inline comments.


================
Comment at: lib/Support/ScopHelper.cpp:475
 
     bool DominatesAllPredecessors = true;
+    if (R.isTopLevelRegion()) {
----------------
bollu wrote:
> Could you please add a link to the test case? I'm not sure what the Polly convention on this is, but having a reference to what code path this covers would be helpful in the future :) [Something like this is what I have in mind](https://github.com/llvm-mirror/polly/blob/805fc1012c19b31b651a41c7064de160d661c9df/lib/CodeGen/IslNodeBuilder.cpp#L370)
I really don't like the idea. Is there precedent for this in polly or llvm (besides the one @bollu posted)?




Repository:
  rL LLVM

https://reviews.llvm.org/D40492