[PATCH] D40492: Handle Top-Level-Regions in polly::isHoistableLoad

[Siddharth via Phabricator via llvm-commits]

bollu added a comment.

Other than request for documentation, LGTM. I did not test it, but I reduced the test case with bugpoint, so it should be the right fix. If not, I can complain again ;)



================
Comment at: lib/Support/ScopHelper.cpp:475
 
     bool DominatesAllPredecessors = true;
+    if (R.isTopLevelRegion()) {
----------------
Could you please add a link to the test case? I'm not sure what the Polly convention on this is, but having a reference to what code path this covers would be helpful in the future :) [Something like this is what I have in mind](https://github.com/llvm-mirror/polly/blob/805fc1012c19b31b651a41c7064de160d661c9df/lib/CodeGen/IslNodeBuilder.cpp#L370)


Repository:
  rL LLVM

https://reviews.llvm.org/D40492