[PATCH] D39193: [ARM] Don't omit non-default predication code

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 21 05:19:54 PST 2017


rengolin added inline comments.


================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:5810
                                               OperandVector &Operands) {
   // VRINT{Z, R, X} have a predicate operand in VFP, but not in NEON
   unsigned RegIdx = 3;
----------------
update comment?


================
Comment at: test/MC/ARM/invalid-neon-v8.s:76
+
+// These instructions are predicable in VFP but not in NEON
+vrintzeq.f32 d0, d1
----------------
do we have tests for when it's valid? for all three R,X,Z variants?


Repository:
  rL LLVM

https://reviews.llvm.org/D39193





More information about the llvm-commits mailing list