[PATCH] D39193: [ARM] Don't omit non-default predication code

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 21 07:25:44 PST 2017


olista01 added inline comments.


================
Comment at: test/MC/ARM/invalid-neon-v8.s:76
+
+// These instructions are predicable in VFP but not in NEON
+vrintzeq.f32 d0, d1
----------------
rengolin wrote:
> do we have tests for when it's valid? for all three R,X,Z variants?
Yes, there are tests for the conditional and unconditional VFP versions in test/MC/ARM/fp-armv8.s and test/MC/ARM/thumb-fp-armv8.s, and the unconditional NEON case in test/MC/ARM/neon-v8.s.


Repository:
  rL LLVM

https://reviews.llvm.org/D39193





More information about the llvm-commits mailing list