[PATCH] D39898: [RISCV] Add custom CC_RISCV calling convention and improved call support

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:659
 
-  for (auto &Arg : Outs) {
-    if (!Arg.Flags.isByVal())
+  // Create local copies for byval args
+  SmallVector<SDValue, 8> ByValArgs;
----------------
Period after comment.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:824
+  CCState CCInfo(CallConv, IsVarArg, MF, RVLocs, Context);
+  for (unsigned i = 0, e = Outs.size(); i != e; ++i) {
+    MVT VT = Outs[i].VT;
----------------
Any reason to have to lowercase loop variables in some functions and uppercase in some others? Can we make this uniform?


https://reviews.llvm.org/D39898