[PATCH] D40170: [llvm-tblgen] - Stop using std:string in RecordKeeper.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 20 03:54:22 PST 2017


>Ok, just a suggestion. If it's being iterated over it may not be safe to change. Lgtm otherwise

Thanks for looking !

And sorry, but I just found this patch would break one place.
(It is https://github.com/llvm-mirror/llvm/blob/master/utils/TableGen/CTagsEmitter.cpp#L34, which
constructor takes std::string by reference and stores pointer as member,
but with change introduced by this patch it looks would store pointer to temporarily
std::string object created from StringRef passed now). I am going to update this patch a bit later.

George.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171120/ab1b7769/attachment-0001.html>


More information about the llvm-commits mailing list