
<html>

<head>

<meta http-equiv="Content-Type" content="text/html; charset=koi8-r">

<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>

</head>

<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">

<p>><span style="color: rgb(33, 33, 33); font-size: 12pt;">Ok, just a suggestion. If it’s being iterated over it may not be safe to change. Lgtm otherwise </span></p>

<div style="color: rgb(33, 33, 33);">

<div>

<div class="gmail_quote">

<div dir="ltr"><br>

</div>

Thanks for looking ! <br>

</div>

<div class="gmail_quote"><br>

</div>

<div class="gmail_quote">And sorry, but I just found this patch would break one place.<br>

</div>

<div class="gmail_quote">(It is <a href="https://github.com/llvm-mirror/llvm/blob/master/utils/TableGen/CTagsEmitter.cpp#L34">https://github.com/llvm-mirror/llvm/blob/master/utils/TableGen/CTagsEmitter.cpp#L34</a>, which<br>

</div>

<div class="gmail_quote">constructor takes std::string by reference and stores pointer as member, </div>

<div class="gmail_quote">but with change introduced by this patch it looks <span style="font-size: 12pt;">would store pointer </span><span style="font-size: 12pt;">to temporarily</span></div>

<div class="gmail_quote"><span style="font-size: 12pt;">std::string object created from StringRef passed now</span><span style="font-size: 12pt;">). </span><span style="font-size: 12pt;">I am going to</span><span style="font-size: 12pt;"> update this patch

 a bit later.</span></div>

<div class="gmail_quote"><br>

</div>

<div class="gmail_quote">George.<br>

</div>

</div>

</div>

</body>

</html>