[PATCH] D40155: AMDGPU: Fix breaking SMEM clauses

Tony Tye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 16 19:08:25 PST 2017


t-tye added inline comments.


================
Comment at: lib/Target/AMDGPU/GCNHazardRecognizer.cpp:280
+void GCNHazardRecognizer::addClauseInst(const MachineInstr &MI) {
+  // XXX: Do we need to worry about implicit operands
+  addRegsToSet(TRI, MI.defs(), ClauseDefs);
----------------
Can implicit operands be registers? Is the only such case M0 which can never be modified. So probably not?


https://reviews.llvm.org/D40155





More information about the llvm-commits mailing list