[PATCH] D39712: [ARM] Add an alias for psr and psr_nzcvq

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 10 21:34:41 PST 2017


rengolin requested changes to this revision.
rengolin added a comment.
This revision now requires changes to proceed.

For reference, we tend not to add undocumented stuff. We only add GNU extensions when it's simple and necessary. We specifically don't add things that are implemented in GCC source code or test-cases, as that brings us bug-for-bug emulation, which we purposefully won't do.

This specific case smells like it's implemented in some old asm source (either asm file or inline) and people prefer to add "support" in the compiler rather than change the affected source code.

I'm inclined to agree with everyone else, this is not a good patch, regardless of how simple it is, it can open a can of worms.

So, unless compelling evidence can be shown that this functionality is mandatory, and won't add to the compiler's complexity in the long term, not just "easy to add", we should keep it out.

cheers,
--renato


Repository:
  rL LLVM

https://reviews.llvm.org/D39712





More information about the llvm-commits mailing list