[llvm] r317626 - Fix build bots after r317622

Dave Lee via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 14:46:54 PST 2017


Thanks Craig. An lld test is failing with this change so I'll revert. The
method is intended to be used only when caller knows the name exists in the
lookup.

On Tue, Nov 7, 2017 at 2:37 PM, Craig Topper <craig.topper at gmail.com> wrote:

> This wil always return 0 in a release build. Is that what you want? Or
> should it be calling lookup in release builds?
>
> ~Craig
>
> On Tue, Nov 7, 2017 at 2:33 PM, Dave Lee via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: kastiglione
>> Date: Tue Nov  7 14:33:07 2017
>> New Revision: 317626
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=317626&view=rev
>> Log:
>> Fix build bots after r317622
>>
>> Example build failure: http://lab.llvm.org:8011/build
>> ers/lld-x86_64-darwin13/builds/14660
>>
>> TIL that the warning flags for local builds are loose compared to what
>> build
>> servers use.
>>
>> Modified:
>>     llvm/trunk/tools/yaml2obj/yaml2elf.cpp
>>
>> Modified: llvm/trunk/tools/yaml2obj/yaml2elf.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/yaml2ob
>> j/yaml2elf.cpp?rev=317626&r1=317625&r2=317626&view=diff
>> ============================================================
>> ==================
>> --- llvm/trunk/tools/yaml2obj/yaml2elf.cpp (original)
>> +++ llvm/trunk/tools/yaml2obj/yaml2elf.cpp Tue Nov  7 14:33:07 2017
>> @@ -76,7 +76,7 @@ public:
>>    }
>>    /// asserts if name is not present in the map
>>    unsigned get(StringRef Name) const {
>> -    unsigned Idx;
>> +    unsigned Idx = 0;
>>      assert(!lookup(Name, Idx) && "Expected section not found in index");
>>      return Idx;
>>    }
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171107/f25a761d/attachment.html>


More information about the llvm-commits mailing list