<div dir="ltr">Thanks Craig. An lld test is failing with this change so I'll revert. The method is intended to be used only when caller knows the name exists in the lookup.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 7, 2017 at 2:37 PM, Craig Topper <span dir="ltr"><<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This wil always return 0 in a release build. Is that what you want? Or should it be calling lookup in release builds?</div><div class="gmail_extra"><br clear="all"><div><div class="m_8838946954225299288gmail_signature" data-smartmail="gmail_signature">~Craig</div></div>
<br><div class="gmail_quote">On Tue, Nov 7, 2017 at 2:33 PM, Dave Lee via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: kastiglione<br>
Date: Tue Nov  7 14:33:07 2017<br>
New Revision: 317626<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=317626&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=317626&view=rev</a><br>
Log:<br>
Fix build bots after r317622<br>
<br>
Example build failure: <a href="http://lab.llvm.org:8011/builders/lld-x86_64-darwin13/builds/14660" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/build<wbr>ers/lld-x86_64-darwin13/builds<wbr>/14660</a><br>
<br>
TIL that the warning flags for local builds are loose compared to what build<br>
servers use.<br>
<br>
Modified:<br>
    llvm/trunk/tools/yaml2obj/yaml<wbr>2elf.cpp<br>
<br>
Modified: llvm/trunk/tools/yaml2obj/yaml<wbr>2elf.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/yaml2obj/yaml2elf.cpp?rev=317626&r1=317625&r2=317626&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/tools/yaml2ob<wbr>j/yaml2elf.cpp?rev=317626&r1=<wbr>317625&r2=317626&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/tools/yaml2obj/yaml<wbr>2elf.cpp (original)<br>
+++ llvm/trunk/tools/yaml2obj/yaml<wbr>2elf.cpp Tue Nov  7 14:33:07 2017<br>
@@ -76,7 +76,7 @@ public:<br>
   }<br>
   /// asserts if name is not present in the map<br>
   unsigned get(StringRef Name) const {<br>
-    unsigned Idx;<br>
+    unsigned Idx = 0;<br>
     assert(!lookup(Name, Idx) && "Expected section not found in index");<br>
     return Idx;<br>
   }<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</blockquote></div><br></div>