[PATCH] D38313: [InstCombine] Introducing Pattern Instruction Combine plug-in into InstCombine pass

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 25 15:40:18 PDT 2017


spatel added a comment.

In https://reviews.llvm.org/D38313#906667, @aaboud wrote:

> To summarize, I really do not mind to move it to separate pass, but I would like to make this optimization committed as soon as possible.
>  I appreciate your review and direction, please, advice with the best way you think I should implement this optimization.


As I said, I'm deferring to others on the way forward, so if everyone else thinks this is good, then I'm not objecting. Others have looked at the code closer than me, so I'll let them provide more feedback and/or approval.


https://reviews.llvm.org/D38313





More information about the llvm-commits mailing list