[PATCH] D38313: [InstCombine] Introducing Pattern Instruction Combine plug-in into InstCombine pass

[Amjad Aboud via Phabricator via llvm-commits]

aaboud added a comment.

In https://reviews.llvm.org/D38313#907218, @spatel wrote:

> In https://reviews.llvm.org/D38313#906667, @aaboud wrote:
>
> > To summarize, I really do not mind to move it to separate pass, but I would like to make this optimization committed as soon as possible.
> >  I appreciate your review and direction, please, advice with the best way you think I should implement this optimization.
>
>
> As I said, I'm deferring to others on the way forward, so if everyone else thinks this is good, then I'm not objecting. Others have looked at the code closer than me, so I'll let them provide more feedback and/or approval.


Thanks Sanjay,
I appreciate your help.
I will be waiting a little more for others to comment on this patch.


https://reviews.llvm.org/D38313