[PATCH] D38960: [Local] Fix a bug in the domtree update logic for MergeBasicBlockIntoOnlyPred.

[Balaram Makam via llvm-commits]

Thanks Danny,

 

I manually reduced the testcase to this:

 

define i32 @f(i8* %str) {

entry:

  br label %bb2.i

 

bb2.i:                                            ; preds = %bb4.i, %entry

  br i1 false, label %bb4.i, label %base2flt.exit204

 

bb4.i:                                            ; preds = %bb2.i

  br i1 false, label %base2flt.exit204, label %bb2.i

 

bb10.i196.bb7.i197_crit_edge:                     ; No predecessors!

  br label %bb7.i197

 

bb7.i197:                                         ; preds = %bb10.i196.bb7.i197_crit_edge

  %.reg2mem.0 = phi i32 [ %.reg2mem.0, %bb10.i196.bb7.i197_crit_edge ]

  br i1 undef, label %base2flt.exit204, label %base2flt.exit204

 

base2flt.exit204:                                 ; preds = %bb7.i197, %bb7.i197, %bb2.i, %bb4.i

  ret i32 0

}

 

I updated the unittest on the phabricator too. Please take a look.

 

Thanks,

Balaram

From: Daniel Berlin [mailto:dberlin at dberlin.org] 
Sent: Tuesday, October 17, 2017 12:14 PM
To: reviews+D38960+public+4783ff864e64ecda at reviews.llvm.org; Hal Finkel via Phabricator <reviews at reviews.llvm.org>
Cc: bmakam at codeaurora.org; Kuba Kuderski <kubakuderski at gmail.com>; llvm-commits at lists.llvm.org
Subject: Re: [PATCH] D38960: [Local] Fix a bug in the domtree update logic for MergeBasicBlockIntoOnlyPred.

 

Send me a test case that fails under bugpoint (and the command line to use) and I'll try some of my reduction tools on it.

 

On Tue, Oct 17, 2017, 9:11 AM Balaram Makam via Phabricator via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org> > wrote:

bmakam added a comment.

In https://reviews.llvm.org/D38960#899142, @kuhar wrote:

> Thanks for adding the comment.
>
> The testcase seems really long and it's not obvious why what it tries to exercise -- have you tried reducing it with bugpoint to something shorter and easier to reason about?


Sorry for the long testcase, but this untitest was extracted after using bugpoint to reduce the lit test in test/Transforms/CodeGenPrepare/2008-11-24-RAUW-Self.ll. Is there a way to reduce a unittest using bugpoint?


https://reviews.llvm.org/D38960



_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org> 
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171017/550a95e7/attachment.html>