<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal>Thanks Danny,<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>I manually reduced the testcase to this:<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>define i32 @f(i8* %str) {<o:p></o:p></p><p class=MsoNormal>entry:<o:p></o:p></p><p class=MsoNormal> br label %bb2.i<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>bb2.i: ; preds = %bb4.i, %entry<o:p></o:p></p><p class=MsoNormal> br i1 false, label %bb4.i, label %base2flt.exit204<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>bb4.i: ; preds = %bb2.i<o:p></o:p></p><p class=MsoNormal> br i1 false, label %base2flt.exit204, label %bb2.i<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>bb10.i196.bb7.i197_crit_edge: ; No predecessors!<o:p></o:p></p><p class=MsoNormal> br label %bb7.i197<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>bb7.i197: ; preds = %bb10.i196.bb7.i197_crit_edge<o:p></o:p></p><p class=MsoNormal> %.reg2mem.0 = phi i32 [ %.reg2mem.0, %bb10.i196.bb7.i197_crit_edge ]<o:p></o:p></p><p class=MsoNormal> br i1 undef, label %base2flt.exit204, label %base2flt.exit204<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>base2flt.exit204: ; preds = %bb7.i197, %bb7.i197, %bb2.i, %bb4.i<o:p></o:p></p><p class=MsoNormal> ret i32 0<o:p></o:p></p><p class=MsoNormal>}<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>I updated the unittest on the phabricator too. Please take a look.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Thanks,<o:p></o:p></p><p class=MsoNormal>Balaram<o:p></o:p></p><p class=MsoNormal><b>From:</b> Daniel Berlin [mailto:dberlin@dberlin.org] <br><b>Sent:</b> Tuesday, October 17, 2017 12:14 PM<br><b>To:</b> reviews+D38960+public+4783ff864e64ecda@reviews.llvm.org; Hal Finkel via Phabricator <reviews@reviews.llvm.org><br><b>Cc:</b> bmakam@codeaurora.org; Kuba Kuderski <kubakuderski@gmail.com>; llvm-commits@lists.llvm.org<br><b>Subject:</b> Re: [PATCH] D38960: [Local] Fix a bug in the domtree update logic for MergeBasicBlockIntoOnlyPred.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Send me a test case that fails under bugpoint (and the command line to use) and I'll try some of my reduction tools on it.<o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p><div><div><p class=MsoNormal>On Tue, Oct 17, 2017, 9:11 AM Balaram Makam via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<o:p></o:p></p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'><p class=MsoNormal>bmakam added a comment.<br><br>In <a href="https://reviews.llvm.org/D38960#899142" target="_blank">https://reviews.llvm.org/D38960#899142</a>, @kuhar wrote:<br><br>> Thanks for adding the comment.<br>><br>> The testcase seems really long and it's not obvious why what it tries to exercise -- have you tried reducing it with bugpoint to something shorter and easier to reason about?<br><br><br>Sorry for the long testcase, but this untitest was extracted after using bugpoint to reduce the lit test in test/Transforms/CodeGenPrepare/2008-11-24-RAUW-Self.ll. Is there a way to reduce a unittest using bugpoint?<br><br><br><a href="https://reviews.llvm.org/D38960" target="_blank">https://reviews.llvm.org/D38960</a><br><br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><o:p></o:p></p></blockquote></div></div></div></body></html>