[PATCH] D38914: AMDGPU: Select s_buffer_load_dword with a non-constant SGPR offset

[Marek Olšák via Phabricator via llvm-commits]

mareko added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:3720-3723
+        .addImm(0) // soffset
+        .addImm(0) // offset
+        .addImm(0) // glc
+        .addImm(0) // slc
----------------
arsenm wrote:
> Don't these need to be preserved from the input? Especially the offsets
S_BUFFER_LOAD_DWORD_SGPR doesn't have soffset, offset, slc. It only has soff (which is now VGPR) and glc, but glc can't be 1 currently.


https://reviews.llvm.org/D38914