[PATCH] D38914: AMDGPU: Select s_buffer_load_dword with a non-constant SGPR offset

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 16 14:45:43 PDT 2017


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:3720-3723
+        .addImm(0) // soffset
+        .addImm(0) // offset
+        .addImm(0) // glc
+        .addImm(0) // slc
----------------
Don't these need to be preserved from the input? Especially the offsets


https://reviews.llvm.org/D38914





More information about the llvm-commits mailing list