[PATCH] D38712: [ELF] Try to not emit weird diagnostics on undefined symbols

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/ELF/pr34872.s:8
+# CHECK: undefined symbol: fmod
+# CHECK-NOT: 'fmod' defined in {{.*}} has no type
+
----------------
davide wrote:
> grimar wrote:
> > Testing full error message with `NOT` is probably brittle and
> > can make check useless if we change message. 
> > I would just check we have no other errors about symbol:
> > `#CHECK-NOT: fmod`
> > 
> it's unlikely this message will change imho.
+1 for @grimar's suggestion. We cannot predict how the error messages might change in the future: even if it's unlikely, it's still possible that they might for some reason (e.g. we might decide to do a wholesale change in their structure, like the move to change to multi-line errors for duplicate symbols).


https://reviews.llvm.org/D38712