[PATCH] D38712: [ELF] Try to not emit weird diagnostics on undefined symbols

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 10 00:58:28 PDT 2017


davide added inline comments.


================
Comment at: test/ELF/pr34872.s:8
+# CHECK: undefined symbol: fmod
+# CHECK-NOT: 'fmod' defined in {{.*}} has no type
+
----------------
grimar wrote:
> Testing full error message with `NOT` is probably brittle and
> can make check useless if we change message. 
> I would just check we have no other errors about symbol:
> `#CHECK-NOT: fmod`
> 
it's unlikely this message will change imho.


https://reviews.llvm.org/D38712





More information about the llvm-commits mailing list